Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workflow to test standalone plugins built from modules as no longer relevant #1071

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Remove workflow to test standalone plugins built from modules as no longer relevant #1071

merged 2 commits into from
Mar 21, 2024

Conversation

felixarntz
Copy link
Member

Summary

Follow up to #1060.
See #1030.

This removes the test-plugins script and surrounding workflow, which was used only to check for fatal errors in plugins built from standalone plugins. This is no longer relevant given modules no longer exist.

Note: This change has nothing to do with PHPUnit tests. The php-test-plugins.yml workflow is the workflow that covers the standalone plugins' PHPUnit tests, and is still relevant.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure Creating standalone plugins skip changelog PRs that should not be mentioned in changelogs labels Mar 21, 2024
@felixarntz felixarntz added this to the performance-lab 3.0.0 milestone Mar 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: thelovekesh <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@felixarntz felixarntz mentioned this pull request Mar 21, 2024
Closed
thelovekesh
thelovekesh approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@thelovekesh thelovekesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixarntz.

@westonruter westonruter merged commit f7fadaf into trunk Mar 21, 2024
26 checks passed
@westonruter westonruter deleted the remove/test-standalone-plugins branch March 21, 2024 18:40
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelovekesh thelovekesh thelovekesh approved these changes

@westonruter westonruter westonruter approved these changes

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27 mukeshpanchal27 is a code owner

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
performance-lab 3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@felixarntz @westonruter @thelovekesh